Comment #3 on issue 298 by [email protected]: protobuf jar's manifest
should include OSGi metadata
http://code.google.com/p/protobuf/issues/detail?id=298
Couldn't hold myself from looking into this :) Please find the first
version of the patch attached (sorry if it's not in accepted format - this
is the first time I try to contribute).
There is one concern though. I've noticed that you use "2.4.2-pre" as an
intermediate version number. As far as I know, OSGi spec requires all
components to be separated by dots, so "2.4.2.pre" would be correct.
Without this change, installing such a bundle (jar) into OSGi container
will fail. So, I can see two approaches we can take:
1) Name intermediate versions as OSGi requires (using dots)
2) Create a separate property like "osgi.version"
I would vote for the approach 1), since it avoids duplication.
To my best knowledge, the generated manifest should look like this (feel
free to suggest if something looks wrong):
Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven
Built-By: ann
Build-Jdk: 1.6.0_21
Bundle-ManifestVersion: 2
Bundle-SymbolicName: com.google.protobuf
Bundle-Version: 2.4.2.pre
Bundle-Name: Protocol Buffer Java API
Bundle-Description: Protocol Buffers are a way of encoding structured
data in an efficient yet extensible format.
Bundle-Vendor: googlecode.com
Bundle-DocURL: http://code.google.com/p/protobuf
Bundle-Category: newtwork, library
Bundle-License: http://www.opensource.org/licenses/bsd-license.php
Bundle-RequiredExecutionEnvironment: J2SE-1.5
Export-Package: com.google.protobuf;version="2.4.2.pre"
Attachments:
osgi.patch 2.0 KB
--
You received this message because you are subscribed to the Google Groups "Protocol
Buffers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/protobuf?hl=en.
