On Wed, Nov 11, 2015 at 4:46 PM, Feng Xiao <xiaof...@google.com> wrote:
> > > On Tue, Nov 10, 2015 at 7:04 PM, Abhishek Parmar <abhis...@carbon3d.com> > wrote: > >> I am using v3.0.0-beta-1 >> >> Based on a quick read of the code I thought >> google/protobuf/util/internal/protostream_objectwriter.cc >> was not doing error checks in method >> ProtoStreamObjectWriter::AnyWriter::RenderDataPiece >> >> There was a TODO to make attention to status which seem to have been >> fixed in v3.0.0-beta-1-bzl-fix. I tried that and it seems no better. >> >> So perhaps there is something else that I am missing. FWIW my code is >> closely modeled after json_util_test.cc >> >> Any help will be greatly appreciated. >> > By mistyped fields do you mean the Any type url is incorrect? The JSON > conversion code should report an error for that. If it's not, could you > file an issue on our github site? > I mean that if a fields for example is of type int32 and the json contains a string, it silently drops the field. I amanaged to debug a bit more and seems like this is by design as the STRING type DataPiece gets safely converted to a number? But I saw similar behavior for even nested messages. The parser just silently drops fields that do not match the type in the protobuffer. If this is intentional, then perhaps we should have a strict mode. Let me know what you think. > > >> >> Thanks >> Abhishek >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Protocol Buffers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to protobuf+unsubscr...@googlegroups.com. >> To post to this group, send email to protobuf@googlegroups.com. >> Visit this group at http://groups.google.com/group/protobuf. >> For more options, visit https://groups.google.com/d/optout. >> > > -- -Abhishek -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to protobuf+unsubscr...@googlegroups.com. To post to this group, send email to protobuf@googlegroups.com. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/d/optout.
