Just a heads up, I've committed this to trunk. Please let me know if it causes any problems.
--Rafael On Tue, Apr 29, 2014 at 2:57 PM, Rafael Schloming <r...@alum.mit.edu> wrote: > Hi Everyone, > > I've put together a patch that makes the proton-j factory usage a bit > simpler and more consistent. You can review it here if you like: > > - https://reviews.apache.org/r/20854/ > > The main point of the patch is to make all the factories consistently > follow this pattern: > > package.Interface iface = package.Interface.Factory.create(...); > > I like this because it is simple and easy to remember and doesn't require > importing the impl packages directly. > > The patch preserves the convenience constructors, e.g. Proton.connection() > and so forth, but it does remove the old factory APIs. I think this is a > reasonable thing to do because the old factories were cumbersome enough to > use that I don't think anyone actually bothered (including our own > exmaples). > > In any case, please shout if this patch will be troublesome for you. If I > don't hear anything I'll go ahead and commit it later this week. > > Thanks, > > --Rafael > >