[ 
https://issues.apache.org/jira/browse/PROTON-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143409#comment-14143409
 ] 

Robbie Gemmell commented on PROTON-694:
---------------------------------------

Downloaded change from 
https://github.com/clebertsuconic/qpid-proton/commit/0626fc4da878c8b8f8e7960a17b6ad70ec999028.patch
 to examine.

{noformat}
@@ -223,7 +226,8 @@ static EncodedMessage 
transform(JMSMappingOutboundTransformer options, Message m
             c = amqp.encode(new WritableBuffer.ByteBufferWrapper(buffer));
         }
 
-        return new EncodedMessage(messageFormat, buffer.array(), 0, c);
+        return (ProtonJMessage) org.apache.qpid.proton.message.Message.Factory
+                .create(header, da, ma, props, ap, body, footer);
     }
 
     private static String destinationAttributes(Destination destination) {
{noformat}

In the above snippet he patch returns a new ProtonJ message from the new 
convert method insead of the previous EncodedMessage returned, and then 
elsewhere adds a new encoding step using that ProtonJ message...but doesnt 
remove any existing encoding. This combined with the above context containing 
another encode call suggests it is now double-encoding, is that intended?

If the change needs updated, please attach the patch here instead of linking to 
a branch.

> splitting contrib/JMSMappingOutboundTransformer's encoding and transformation
> -----------------------------------------------------------------------------
>
>                 Key: PROTON-694
>                 URL: https://issues.apache.org/jira/browse/PROTON-694
>             Project: Qpid Proton
>          Issue Type: Bug
>            Reporter: clebert suconic
>
> I just need the transformation from this method, not the actual encoding.
> I need to later encode the ProtonJMessage using NettyBuffer which is pooled 
> and more efficient than the method done within JMSMappingOutboundTransformer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to