[ 
https://issues.apache.org/jira/browse/PROTON-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143573#comment-14143573
 ] 

Robbie Gemmell commented on PROTON-694:
---------------------------------------

Looking at the applied patch now, I see it adds a new method, convert(..) which 
splits out most of the previous transform(..) implementation and is then called 
from the still-remaining transform(..) method. The last things convert(..) does 
after applying the patch is create a ProtonJ message, encode it to a buffer, 
then create a second ProtonJ message and then return it. When called from 
transform(..) the returned message is then encoded to another buffer which gets 
returned via an EncodedMessage as previously. Surely the first encode there 
isnt needed?

> splitting contrib/JMSMappingOutboundTransformer's encoding and transformation
> -----------------------------------------------------------------------------
>
>                 Key: PROTON-694
>                 URL: https://issues.apache.org/jira/browse/PROTON-694
>             Project: Qpid Proton
>          Issue Type: Bug
>            Reporter: clebert suconic
>
> I just need the transformation from this method, not the actual encoding.
> I need to later encode the ProtonJMessage using NettyBuffer which is pooled 
> and more efficient than the method done within JMSMappingOutboundTransformer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to