Github user rhs commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/28#discussion_r29751867
  
    --- Diff: bin/export.sh ---
    @@ -54,15 +65,18 @@ WORKDIR=$(mktemp -d)
     ##
     (
         cd ${SRC}
    -    TAG=$(git describe --tags --always)
         MTIME=$(date -d @`git log -1 --pretty=format:%ct tags/${TAG}` 
'+%Y-%m-%d %H:%M:%S')
         ARCHIVE=$DIR/qpid-proton-${TAG}.tar.gz
    +    VERSION=$(git show tags/${TAG}:version.txt)
    +    PREFIX=qpid-proton-${VERSION}
         [ -d ${WORKDIR} ] || mkdir -p ${WORKDIR}
    -    git archive --format=tar --prefix=qpid-proton-${TAG}/ tags/${TAG} \
    +    git archive --format=tar --prefix=${PREFIX}/ tags/${TAG} \
             | tar -x -C ${WORKDIR}
    +    ${SRC}/bin/version.sh ${WORKDIR}/${PREFIX} ${VERSION}
    --- End diff --
    
    This doesn't make sense to me. This script is supposed to simply export 
exactly the contents of a tag in the git repo. This tag is generally a signed 
release, and running scripts over the content of the release will invalidate 
that process entirely.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to