Github user rhs commented on the pull request:

    https://github.com/apache/qpid-proton/pull/28#issuecomment-99428883
  
    Fixing the prefix in the tarball makes sense to me, however some of the 
other changes do not. The release process is supposed to proceed from a signed 
tag, which means that if the version for that signed tag is wrong, then 
something prior in the process has gone wrong.
    
    In general having export.sh modify the contents of the exported source tree 
in any way is dangerous since it will lead to divergence between the contents 
of the git tag for a given release and the contents of the exported tarballs 
for that release, and that is obviously really bad.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to