[
https://issues.apache.org/jira/browse/PROTON-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549370#comment-14549370
]
ASF GitHub Bot commented on PROTON-881:
---------------------------------------
GitHub user prestona opened a pull request:
https://github.com/apache/qpid-proton/pull/31
PROTON-881: make unittests check for Java I/O object leaks
This implements an interface which is similar to pn_io - so that the
various Java I/O resources (e.g. Selector, Pipe, SocketChannel, and
ServerSocketChannel) are all created in a single place.
The new IO interface is used by a new test class: LeakTestReactor to extend
ReactorImpl with logic for detecting when a Java I/O resource is _not_ closed
by a testcase.
The Reactor unit tests have been parameterized to run once with the reactor
implementation returned from Proton.reactor() and once with the LeakTestReactor
test class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prestona/qpid-proton reactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 2d3cefc4562e2246a9007d500cf2885ad9b8adc6
Author: Adrian Preston <prest...@uk.ibm.com>
Date: 2015-05-18T22:07:22Z
PROTON-881: make unittests check for Java I/O object leaks
Implements something similar to pn_io so that the various Java I/O
resources are
created in a single place. Reactor unit tests are parameterized to run
once with
the reactor implementation returned from Proton.reactor() and once from a
unittest extension of ReactorImpl which checks that all Java I/O resources,
used
by testcase, are closed.
----
> Proton-j reactor implementation
> -------------------------------
>
> Key: PROTON-881
> URL: https://issues.apache.org/jira/browse/PROTON-881
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: 0.9
> Reporter: Adrian Preston
> Priority: Minor
>
> To keep the proton-j codebase consistent with proton-c - there should be a
> native Java port of the reactor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
