[
https://issues.apache.org/jira/browse/PROTON-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570887#comment-14570887
]
ASF GitHub Bot commented on PROTON-881:
---------------------------------------
Github user rhs commented on the pull request:
https://github.com/apache/qpid-proton/pull/34#issuecomment-108444308
Hi Preston, sorry to take so long to look at this.
My impulse here would be to avoid using a checked exception for
HandlerException. I generally follow the advice that you should only use
checked exceptions for error conditions that a programmer can anticipate and
recover from, and I'm not sure that's the case here. It's nice to have the
HandlerException for debugging and clarity so it's obvious when the handler is
at fault rather than the reactor implementation itself, but I'm not sure how
someone could catch and recover if it is thrown. Making it unchecked would also
allow you to avoid the EventImpl changes you mention in your comment.
> Proton-j reactor implementation
> -------------------------------
>
> Key: PROTON-881
> URL: https://issues.apache.org/jira/browse/PROTON-881
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: 0.9
> Reporter: Adrian Preston
> Priority: Minor
>
> To keep the proton-j codebase consistent with proton-c - there should be a
> native Java port of the reactor.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
