Github user rhs commented on the pull request: https://github.com/apache/qpid-proton/pull/34#issuecomment-108444308 Hi Preston, sorry to take so long to look at this. My impulse here would be to avoid using a checked exception for HandlerException. I generally follow the advice that you should only use checked exceptions for error conditions that a programmer can anticipate and recover from, and I'm not sure that's the case here. It's nice to have the HandlerException for debugging and clarity so it's obvious when the handler is at fault rather than the reactor implementation itself, but I'm not sure how someone could catch and recover if it is thrown. Making it unchecked would also allow you to avoid the EventImpl changes you mention in your comment.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---