[ 
https://issues.apache.org/jira/browse/PROTON-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653383#comment-14653383
 ] 

ASF GitHub Bot commented on PROTON-964:
---------------------------------------

Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/48#discussion_r36173162
  
    --- Diff: 
proton-j/src/main/java/org/apache/qpid/proton/engine/BuiltinHandler.java ---
    @@ -0,0 +1,71 @@
    +/*
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + *
    + */
    +package org.apache.qpid.proton.engine;
    +
    +public interface BuiltinHandler extends Handler {
    +    void onConnectionInit(Event e);
    +    void onConnectionLocalOpen(Event e);
    +    void onConnectionRemoteOpen(Event e);
    +    void onConnectionLocalClose(Event e);
    +    void onConnectionRemoteClose(Event e);
    +    void onConnectionBound(Event e);
    +    void onConnectionUnbound(Event e);
    +    void onConnectionFinal(Event e);
    +
    +    void onSessionInit(Event e);
    +    void onSessionLocalOpen(Event e);
    +    void onSessionRemoteOpen(Event e);
    +    void onSessionLocalClose(Event e);
    +    void onSessionRemoteClose(Event e);
    +    void onSessionFinal(Event e);
    +
    +    void onLinkInit(Event e);
    +    void onLinkLocalOpen(Event e);
    +    void onLinkRemoteOpen(Event e);
    +    void onLinkLocalDetach(Event e);
    +    void onLinkRemoteDetach(Event e);
    +    void onLinkLocalClose(Event e);
    +    void onLinkRemoteClose(Event e);
    +    void onLinkFlow(Event e);
    +    void onLinkFinal(Event e);
    +
    +    void onDelivery(Event e);
    +    void onTransport(Event e);
    +    void onTransportError(Event e);
    +    void onTransportHeadClosed(Event e);
    +    void onTransportTailClosed(Event e);
    +    void onTransportClosed(Event e);
    +
    +    void onReactorInit(Event e);
    --- End diff --
    
    I think it could be argued that the reactor-specific events might be better 
in their own extended handler, but they aren't currently so lets save that for 
later ;)


> Proton-J extensible event types
> -------------------------------
>
>                 Key: PROTON-964
>                 URL: https://issues.apache.org/jira/browse/PROTON-964
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-j
>    Affects Versions: 0.10
>            Reporter: Bozo Dragojevic
>            Assignee: Bozo Dragojevic
>             Fix For: 0.11
>
>
> Event.Type is an enum which makes it impossible to extend.
> Introduce a separate interface EventType and make Event.Type implement it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to