[ 
https://issues.apache.org/jira/browse/PROTON-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653402#comment-14653402
 ] 

ASF GitHub Bot commented on PROTON-964:
---------------------------------------

Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/48#discussion_r36174093
  
    --- Diff: 
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/BuiltinEventTypeImpl.java
 ---
    @@ -0,0 +1,144 @@
    +package org.apache.qpid.proton.engine.impl;
    +
    +import org.apache.qpid.proton.engine.BuiltinHandler;
    +import org.apache.qpid.proton.engine.Event;
    +import org.apache.qpid.proton.engine.Handler;
    +
    +public class BuiltinEventTypeImpl {
    --- End diff --
    
    This seems to be dispatcher-specific, might be clearer if we named it so?
    
    Same as before regarding the 'Builtin'.


> Proton-J extensible event types
> -------------------------------
>
>                 Key: PROTON-964
>                 URL: https://issues.apache.org/jira/browse/PROTON-964
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-j
>    Affects Versions: 0.10
>            Reporter: Bozo Dragojevic
>            Assignee: Bozo Dragojevic
>             Fix For: 0.11
>
>
> Event.Type is an enum which makes it impossible to extend.
> Introduce a separate interface EventType and make Event.Type implement it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to