[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132953#comment-15132953
 ] 

ASF GitHub Bot commented on PROTON-1126:
----------------------------------------

Github user grs commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/64#discussion_r51931527
  
    --- Diff: proton-c/bindings/python/proton/reactor.py ---
    @@ -671,7 +671,11 @@ def connect(self, url=None, urls=None, address=None, 
handler=None, reconnect=Non
             """
             conn = self.connection(handler)
             conn.container = self.container_id or str(generate_uuid())
    -
    +        
    +        conn.offered_capabilities = kwargs.get('offered_capabilities')
    +        conn.desired_capabilities = kwargs.get('desired_capabilities')
    +        conn.properties = kwargs.get('properties')
    --- End diff --
    
    looks good


> Allow setting connection properties in BlockingConnection
> ---------------------------------------------------------
>
>                 Key: PROTON-1126
>                 URL: https://issues.apache.org/jira/browse/PROTON-1126
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>    Affects Versions: 0.11.1
>            Reporter: Ganesh Murthy
>            Priority: Minor
>             Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to