[ 
https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132956#comment-15132956
 ] 

ASF GitHub Bot commented on PROTON-1126:
----------------------------------------

Github user grs commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/64#discussion_r51931699
  
    --- Diff: tests/python/proton_tests/utils.py ---
    @@ -72,6 +76,24 @@ def wait(self):
             self.event.wait(self.timeout)
     
     
    +class ConnPropertiesServer(EchoServer):
    +     def __init__(self, url, timeout):
    +        EchoServer.__init__(self, url, timeout)
    +        self.properties_received = False
    +        self.offered_capabilities_received = False
    +        self.desired_capabilities_received = False
    +
    +     def on_link_opening(self, event):
    --- End diff --
    
    this is fine; could also be on_connection_opening which might be clearer in 
intent, but this works also


> Allow setting connection properties in BlockingConnection
> ---------------------------------------------------------
>
>                 Key: PROTON-1126
>                 URL: https://issues.apache.org/jira/browse/PROTON-1126
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>    Affects Versions: 0.11.1
>            Reporter: Ganesh Murthy
>            Priority: Minor
>             Fix For: 0.13.0
>
>
> The BlockingConnection class in proton/bindings/python/proton/utils.py does 
> not have a way to set the connection properties. 
> connection properties are sent as part of the AMQP open frame.
> Allow the connection properties to be set on the BlockingConnection



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to