Github user SreeramGarlapati commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/73#discussion_r59236240
  
    --- Diff: 
proton-j/src/test/java/org/apache/qpid/proton/engine/impl/ssl/SimpleSslTransportWrapperTest.java
 ---
    @@ -117,16 +117,6 @@ public void testInputIncompletePacketInThreeParts()
         }
     
         @Test
    -    public void 
testUnderlyingInputUsingSmallBuffer_receivesAllDecodedInput() throws Exception
    -    {
    -        _underlyingInput.setInputBufferSize(1);
    --- End diff --
    
    I deleted this Test from this File and Moved it to a brand new file for 2 
reasons:
    1) This function has a bug - SetInputBufferSize - sets only the integer 
value. It doesn't change anything with actual Buffer Size.
    2) Since, changing buffer size will change the behavior of 
SimpleSslTransportWrapper - this could impact other testcases in the same file. 
So, moved the Size related test to a separate file...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to