Nice, as always! :)
Two issues:
- Element.setOpacity should probably a "private" method, as it
doesn't $() it's argument for non Gecko/non-IE browsers (different
behaviour), and we should require users to use setStyle
({opacity:blah}) anyway
- camelize() as discussed elsewhere (could be solved by providing a
clone of setStyle that doesn't do the camelizing, Element.updateStyle
() or something, as it really doesn't _set_ the complete style but
just affects the given tuple)
Also, I wonder if we should move all browser-specific redefinitions
to extra files, like h4x0r-ie.js, h4x0r-gecko.js, etc. (can't think
of a good naming scheme), so we don't clutter the base .js files. We
could start a thread on that.
Best,
Thomas
Am 19.02.2007 um 02:40 schrieb Andrew Dupont:
>
> On Feb 18, 6:50 pm, "Martin Ellis" <[EMAIL PROTECTED]> wrote:
>> Anyway we're straying massivly from the topic. The point goes back to
>> the setStyle being a resource hog.
>>
>> How can this be improved as with the heavy dependance of it in
>> script.aculo.us it is in desperate need of reworking.
>
> I just submitted #7585: http://dev.rubyonrails.org/ticket/7585
>
> This patch also serves as an example of how I'd like to overhaul
> Prototype's browser detection.
>
> Discuss.
>
> Cheers,
> Andrew
>
>
> >
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Prototype: Core" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~----------~----~----~----~------~----~------~--~---
