Thanks Andrew. I have slightly updated the patch to make things work for webkit. Was using Prototype.BrowserFeatures.XPath before, but prototype always sets that to false when webkit.
Regards, Nick On 14 nov, 18:36, Andrew Dupont <[EMAIL PROTECTED]> wrote: > Great work, Nick. I'll take a look at this patch when I get a chance. > > Cheers, > Andrew > > On Nov 13, 3:01 pm, Nick Stakenburg <[EMAIL PROTECTED]> wrote: > > > I'm hoping document.viewport.getDimensions() can be improved. > > At the moment I'm using a patched version in <a > > href='http://www.nickstakenburg.com/projects/prototip'>Prototip</a> to keep > > tooltips within the viewport, as it works better then the method from > > trunk. Mootools uses a similar approach. > > > To point out the issues in the current function I've added unit tests. > > They show that resizing an element { position: absolute; top: 0; left: > > 0; } to the viewport causes change in document properties. Those > > properties should not be affected. > > > When resizing and showing overlay layers for example (lightbox), this > > will add extra scrollbars in browsers where those document properties > > are affected. The unit test I've added will run this example as a > > test. > > > Patch and Unit test: <a href='http://dev.rubyonrails.org/ticket/ > > 10148'>http://dev.rubyonrails.org/ticket/10148</a> > > > Thanks for checking it out, > > > Nick --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Prototype: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~----------~----~----~----~------~----~------~--~---
