Hi Tobie,
I did only personnal testing, but i'd prefer ask the question first in
case there was a reason to do that.
I will do the unit test but I think I need RoR to do that, so it could
take a couple of days because I did not know Rails.
btw, I will do the unit test and if it the result is good, I will
submit the patch to GitHub.
thanks for you're quick answer.
--
david
On 13 mai, 13:10, Tobie Langel <tobie.lan...@gmail.com> wrote:
> Have you tried running the unit tests in all browsers with your
> changes?
>
> On May 13, 12:32 pm, david <david.brill...@gmail.com> wrote:
>
> > The original setOpacity function just reset the opacity value in case
> > the value is one. Which means that you use the class value (if
> > exist) :
>
> > setOpacity: function(element, value) {
> > element = $(element);
> > element.style.opacity = (value == 1 || value === '') ? '' :
> > (value < 0.00001) ? 0 : value;
> > return element;
> > },
>
> > I perdsonnally think that the function should react this way:
>
> > setOpacity: function(element, value) {
> > element = $(element);
> > element.style.opacity = (value === '') ? '' :
> > (value < 0.00001) ? 0 : (value > 0.99999) ? 1 :value;
> > return element;
> > },
>
> > My question is if the original function are used this way for a
> > specific browser support?
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Prototype: Core" group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to
prototype-core-unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~----------~----~----~----~------~----~------~--~---
