On Nov 23, 11:06 am, disccomp <[EMAIL PROTECTED]> wrote:
> Request for peer code review:
>
> I'd really appreciate it if anyone has a chance to review the code in
> SVN.

[... snip from svn]

> this.blocks  = { el : $$('#'+ this.options.portalId +' .'+ 
> this.options.blockClass)};

[...]

>     $A(this.blocks.el).each(
>      function (block) {
>        var toggle = block.getElementsByClassName(this.options.toggleClass)[0];
>
>        toggle.observe(
>          'click',
>          function (e) {

[...]

I would prefer event delegation in this case (resulting in less bloat
and better memory consumption).


>
> Thanks -Mark

--
kangax
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Prototype & script.aculo.us" group.
To post to this group, send email to prototype-scriptaculous@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/prototype-scriptaculous?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to