On Thu, Mar 02, 2006 at 08:58:08AM -0800, Ben Pfaff wrote:
I only have a few comments.
Should line-buffer still stay in src/? I think it would be
better to put it in src/language or src/language/lexer, if you
think the dependencies are now appropriate for that.
I'll have another look. Last time I tried to move it, it was
inextricably tied to data/*.c
Depending on how you decide to do header file include paths,
public.h and private.h in src/expressions should perhaps be
renamed.
Certainly if we go down the "lots of -Is" approach; as
#include <public.h> isn't very meaningfull. Perhaps we should decide
on the inclusion issue now. At the moment, I think I'm leaning
towards the explicit #include option --- ie. all dirs are compiled
with -I src -I lib -iquote ./ --- This will mean that things outside the
src/language/expressions dir will need to use
#include <src/language/expressions/public.h> but inside the
expressions dir one can use #include "private.h"
I assume you'll add some kind of summary of changes to
src/ChangeLog before you check in?
Actually I'd put this in ./ChangeLog ; maybe I should move some of the
comments to src/ChangeLog. I've also added empty ChangeLog files for
all the new directories.
J'
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.
signature.asc
Description: Digital signature
_______________________________________________ pspp-dev mailing list [email protected] http://lists.gnu.org/mailman/listinfo/pspp-dev
