Follow-up Comment #1, patch #6071 (project pspp):
Is the datasheet.c assertion correct? I think that the test should be "<="
not "<".
value_cnt_from_width (var_get_width (v)) can be replaced by var_get_value_cnt
(v) in a couple of places.
The procedure for changing the width of a variable in a dictionary in-place
makes me nervous. It seems to me that it's only appropriate in the
particular case where the data is coming from something like a datasheet,
where the case data is automatically rearranged as the dictionary is
manipulated. And in that case, I don't understand why just doing
set_var_width as-is and then dict_compact on its dictionary wouldn't have the
same effect.
If we do need a new in-place resizing procedure, then I'd like
dict_pad_values to be a static function. No need to encourage anything else
to take advantage of it...
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6071>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
pspp-dev mailing list
pspp-dev@gnu.org
http://lists.gnu.org/mailman/listinfo/pspp-dev
