Follow-up Comment #22, patch #6650 (project pspp):
I think that you have made a mistake here:
result->accumulate = (result == LISTWISE) ?
For consistency, I think that covariance_accumulate should be renamed to
covariance_matrix_accumulate.
It would be better if the "missing_value" parameter of covariance_matrix_init
and the "missing_value" member of struct covariance_matrix were both of type
"enum mv_class"
Apart from that, I think this can be committed when you're ready.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6650>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev
