Marc Kleine-Budde wrote:
> From: Michael Grzeschik <[email protected]>

please remove all ", $@" they are obsolete.

more comments inline.

cheers, Marc

> 
> Signed-off-by: Michael Grzeschik <[email protected]>
> ---
>  rules/sox.in   |    6 ++
>  rules/sox.make |  142 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 148 insertions(+), 0 deletions(-)
>  create mode 100644 rules/sox.in
>  create mode 100644 rules/sox.make
> 
> diff --git a/rules/sox.in b/rules/sox.in
> new file mode 100644
> index 0000000..38fe56d
> --- /dev/null
> +++ b/rules/sox.in
> @@ -0,0 +1,6 @@
> +## SECTION=multimedia_sound
> +config SOX
> +     tristate
> +     prompt "sox                        "
> +     help
> +       The GNU audio army knife
> diff --git a/rules/sox.make b/rules/sox.make
> new file mode 100644
> index 0000000..ae43a55
> --- /dev/null
> +++ b/rules/sox.make
> @@ -0,0 +1,142 @@
> +# -*-makefile-*-
> +# $Id: template 2606 2005-05-10 21:49:41Z rsc $

please remove th $Id
> +#
> +# Copyright (C) 2005 by Bjoern Buerger <[email protected]>

please adjust

> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_SOX) += sox
> +
> +#
> +# Paths and names
> +#
> +SOX_VERSION  := 14.3.0
> +SOX          := sox-$(SOX_VERSION)
> +SOX_SUFFIX   := tar.gz
> +SOX_URL      := $(PTXCONF_SETUP_SFMIRROR)/sox/$(SOX).$(SOX_SUFFIX)
> +SOX_SOURCE   := $(SRCDIR)/$(SOX).$(SOX_SUFFIX)
> +SOX_DIR      := $(BUILDDIR)/$(SOX)
> +
> +
> +# 
> ----------------------------------------------------------------------------
> +# Get
> +# 
> ----------------------------------------------------------------------------
> +
> +sox_get: $(STATEDIR)/sox.get

please remove

> +
> +$(STATEDIR)/sox.get: $(sox_get_deps_default)
> +     @$(call targetinfo, $@)
> +     @$(call touch, $@)

please remove

> +
> +$(SOX_SOURCE):
> +     @$(call targetinfo, $@)
> +     @$(call get, SOX)
> +
> +# 
> ----------------------------------------------------------------------------
> +# Extract
> +# 
> ----------------------------------------------------------------------------
> +
> +sox_extract: $(STATEDIR)/sox.extract

please remove

> +
> +$(STATEDIR)/sox.extract: $(sox_extract_deps_default)
> +     @$(call targetinfo, $@)
> +     @$(call clean, $(SOX_DIR))
> +     @$(call extract, SOX)
> +     @$(call patchin, SOX)
> +     @$(call touch, $@)

please remove

> +
> +# 
> ----------------------------------------------------------------------------
> +# Prepare
> +# 
> ----------------------------------------------------------------------------
> +
> +sox_prepare: $(STATEDIR)/sox.prepare

please remove

> +
> +SOX_PATH     := PATH=$(CROSS_PATH)
> +SOX_ENV      := $(CROSS_ENV)

please remove

> +
> +#
> +# autoconf
> +#
> +SOX_AUTOCONF := $(CROSS_AUTOCONF_USR) \
> +     --disable-gomp

please move the $(CROSS_AUTOCONF_USR) into a seperate line

> +
> +
> +
> +$(STATEDIR)/sox.prepare: $(sox_prepare_deps_default)
> +     @$(call targetinfo, $@)
> +     @$(call clean, $(SOX_DIR)/config.cache)
> +     cd $(SOX_DIR) && \
> +             $(SOX_PATH) $(SOX_ENV) \
> +             ./configure $(SOX_AUTOCONF)
> +     @$(call touch, $@)

please remove

> +
> +# 
> ----------------------------------------------------------------------------
> +# Compile
> +# 
> ----------------------------------------------------------------------------
> +
> +sox_compile: $(STATEDIR)/sox.compile

please remove

> +
> +$(STATEDIR)/sox.compile: $(sox_compile_deps_default)
> +     @$(call targetinfo, $@)
> +     cd $(SOX_DIR) && $(SOX_ENV) $(SOX_PATH) make
> +     @$(call touch, $@)

please remove

> +
> +# 
> ----------------------------------------------------------------------------
> +# Install
> +# 
> ----------------------------------------------------------------------------
> +
> +sox_install: $(STATEDIR)/sox.install

please remove

> +
> +$(STATEDIR)/sox.install: $(sox_install_deps_default)
> +     @$(call targetinfo, $@)
> +     @$(call install, SOX)
> +     @$(call touch, $@)

please remove

> +
> +# 
> ----------------------------------------------------------------------------
> +# Target-Install
> +# 
> ----------------------------------------------------------------------------
> +
> +sox_targetinstall: $(STATEDIR)/sox.targetinstall

please remove

> +
> +$(STATEDIR)/sox.targetinstall: $(sox_targetinstall_deps_default)
> +     @$(call targetinfo, $@)
> +
> +     @$(call install_init, sox)
> +     @$(call install_fixup, sox,PACKAGE,sox)
> +     @$(call install_fixup, sox,PRIORITY,optional)
> +     @$(call install_fixup, sox,VERSION,$(SOX_VERSION))
> +     @$(call install_fixup, sox,SECTION,base)
> +     @$(call install_fixup, sox,AUTHOR,"Michael Grzeschik 
> <[email protected]>")
> +     @$(call install_fixup, sox,DEPENDS,)
> +     @$(call install_fixup, sox,DESCRIPTION,missing)
> +
> +     @$(call install_copy, sox, 0, 0, 0755, -, /usr/bin/sox)
> +     @$(call install_link, sox, sox, /usr/bin/soxi)
> +     @$(call install_link, sox, sox, /usr/bin/play)
> +     @$(call install_link, sox, sox, /usr/bin/rec)
> +
> +     @$(call install_copy, sox, 0, 0, 0755, -, /usr/lib/libsox.so.1.0.0)

please install lib 644

> +     @$(call install_link, sox, libsox.so.1.0.0, /usr/lib/libsox.so.1)
> +     @$(call install_link, sox, libsox.so.1.0.0, /usr/lib/libsox.so)
> +
> +     @$(call install_finish, sox)
> +
> +     @$(call touch, $@)
> +
> +# 
> ----------------------------------------------------------------------------
> +# Clean
> +# 
> ----------------------------------------------------------------------------
> +
> +sox_clean:
> +     rm -rf $(STATEDIR)/sox.*
> +     rm -rf $(PKGDIR)/sox_*
> +     rm -rf $(SOX_DIR)
> +

please remove


> +# vim: syntax=make


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
ptxdist mailing list
[email protected]

Reply via email to