Marc Kleine-Budde wrote:
> From: Michael Grzeschik <[email protected]>
> 
comments inline,

cheers, Marc

> Signed-off-by: Michael Grzeschik <[email protected]>
> ---
>  rules/gst-plugins-fluendo.in   |   30 +++++++++++
>  rules/gst-plugins-fluendo.make |  105 
> ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 135 insertions(+), 0 deletions(-)
>  create mode 100644 rules/gst-plugins-fluendo.in
>  create mode 100644 rules/gst-plugins-fluendo.make
> 
> diff --git a/rules/gst-plugins-fluendo.in b/rules/gst-plugins-fluendo.in
> new file mode 100644
> index 0000000..8b883c9
> --- /dev/null
> +++ b/rules/gst-plugins-fluendo.in
> @@ -0,0 +1,30 @@
> +## SECTION=multimedia_gstreamer
> +
> +menuconfig GST_PLUGINS_FLUENDO
> +     tristate
> +     select GLIB
> +     select LIBOIL
> +     select GSTREAMER
> +     select GST_PLUGINS_BASE
> +
> +     prompt "gst-plugins-fluendo              "
> +     help
> +       GStreamer Fluendo Plug-ins is a set of plug-ins that
> +       we consider to have fluendo quality code, correct
> +       functionality, our preferred license (LGPL for the
> +       plug-in code, LGPL or LGPL-compatible for the
> +       supporting library).

you mentioned the mp3 license fee, you may add this to the help text.

> +
> +if GST_PLUGINS_FLUENDO
> +
> +     # ------------------------------
> +     comment "dependencyless plugins"
> +     # ------------------------------

i think this can be removed

> +
> +     config GST_PLUGINS_FLUENDO_MP3
> +             bool
> +             prompt "mp3"
> +
> +endif
> +
> +
> diff --git a/rules/gst-plugins-fluendo.make b/rules/gst-plugins-fluendo.make
> new file mode 100644
> index 0000000..71cbc32
> --- /dev/null
> +++ b/rules/gst-plugins-fluendo.make
> @@ -0,0 +1,105 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2008 by Robert Schwebel

please adjust the copyright

> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_GST_PLUGINS_FLUENDO) += gst-plugins-fluendo
> +
> +#
> +# Paths and names
> +#
> +GST_PLUGINS_FLUENDO_VERSION  := 0.10.10
> +GST_PLUGINS_FLUENDO          := 
> gst-fluendo-mp3-$(GST_PLUGINS_FLUENDO_VERSION)
> +GST_PLUGINS_FLUENDO_SUFFIX   := tar.bz2
> +GST_PLUGINS_FLUENDO_URL              := 
> http://core.fluendo.com/gstreamer/src/gst-fluendo-mp3/$(GST_PLUGINS_FLUENDO).$(GST_PLUGINS_FLUENDO_SUFFIX)
> +GST_PLUGINS_FLUENDO_SOURCE   := 
> $(SRCDIR)/$(GST_PLUGINS_FLUENDO).$(GST_PLUGINS_FLUENDO_SUFFIX)
> +GST_PLUGINS_FLUENDO_DIR              := $(BUILDDIR)/$(GST_PLUGINS_FLUENDO)
> +
> +# 
> ----------------------------------------------------------------------------
> +# Get
> +# 
> ----------------------------------------------------------------------------
> +
> +$(GST_PLUGINS_FLUENDO_SOURCE):
> +     @$(call targetinfo)
> +     @$(call get, GST_PLUGINS_FLUENDO)
> +
> +# 
> ----------------------------------------------------------------------------
> +# Prepare
> +# 
> ----------------------------------------------------------------------------
> +
> +GST_PLUGINS_FLUENDO_ENABLE-$(PTXCONF_GST_PLUGINS_FLUENDO_MP3)        += mp3
> +
> +#
> +# autoconf
> +#
> +# --without-libiconv-prefix -> we use libc iconv
> +#
> +GST_PLUGINS_FLUENDO_CONF_TOOL        := autoconf
> +GST_PLUGINS_FLUENDO_CONF_OPT := \
> +     $(CROSS_AUTOCONF_USR) \
> +     --disable-rpath \
> +     --disable-nls \
> +     --disable-debug \
> +     --disable-profiling \
> +     --disable-valgrind \
> +     --disable-gcov \
> +     --disable-examples \
> +     --enable-external \
> +     --enable-liboil \
> +     --enable-experimental \
> +     --disable-schemas-install \
> +     --disable-gtk-doc \
> +     --disable-gconftool \
> +     --without-libiconv-prefix
> +
> +
> +#
> +# the --with-plugins sadly only applies to depencyless plugings
> +# and when no plugins are sellected it builds them all. So
> +# --with-plugins is useless, so we generate a --enable-*
> +# and --disable-* below
> +#
> +ifneq ($(call remove_quotes,$(GST_PLUGINS_FLUENDO_ENABLE-y)),)
> +GST_PLUGINS_FLUENDO_CONF_OPT +=  --enable-$(subst 
> $(space),$(space)--enable-,$(strip $(GST_PLUGINS_FLUENDO_ENABLE-y)))
> +endif
> +
> +ifneq ($(call remove_quotes,$(GST_PLUGINS_FLUENDO_ENABLE-)),)
> +GST_PLUGINS_FLUENDO_CONF_OPT +=  --disable-$(subst 
> $(space),$(space)--disable-,$(strip $(GST_PLUGINS_FLUENDO_ENABLE-)))
> +endif

I think a simple ifdef PTXCONF_GST_PLUGINS_FLUENDO_MP3 is more
appropriate here.

> +
> +# 
> ----------------------------------------------------------------------------
> +# Target-Install
> +# 
> ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/gst-plugins-fluendo.targetinstall:
> +     @$(call targetinfo)
> +
> +     @$(call install_init, gst-plugins-fluendo)
> +     @$(call install_fixup, gst-plugins-fluendo,PACKAGE,gst-plugins-fluendo)
> +     @$(call install_fixup, gst-plugins-fluendo,PRIORITY,optional)
> +     @$(call install_fixup, 
> gst-plugins-fluendo,VERSION,$(GST_PLUGINS_FLUENDO_VERSION))
> +     @$(call install_fixup, gst-plugins-fluendo,SECTION,base)
> +     @$(call install_fixup, gst-plugins-fluendo,AUTHOR,"Robert Schwebel 
> <[email protected]>")
> +     @$(call install_fixup, gst-plugins-fluendo,DEPENDS,)
> +     @$(call install_fixup, gst-plugins-fluendo,DESCRIPTION,missing)
> +
> +     # install all activated plugins
> +     @if [ -d  $(GST_PLUGINS_FLUENDO_PKGDIR)/usr/lib/gstreamer-0.10/ ]; then 
> \
> +             cd $(GST_PLUGINS_FLUENDO_PKGDIR) && for plugin in `find 
> ./usr/lib/gstreamer-0.10/ -name "*.so"`; do \
> +                     $(call install_copy, gst-plugins-fluendo, 0, 0, 0644, 
> -, /$$plugin); \
> +             done \
> +     fi
> +
> +     @$(call install_finish, gst-plugins-fluendo)
> +
> +     @$(call touch)
> +
> +# vim: syntax=make


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature

-- 
ptxdist mailing list
[email protected]

Reply via email to