Erwin Rol wrote: > Marc Kleine-Budde wrote: >> Erwin Rol wrote: >>> Is that patch acceptable ? >> >> not yet, see comments inline: >> >>>> +# >>>> +# Paths and names >>>> +# >>>> +SQUASHFS_TOOLS_VERSION = $(call ptx/ifdef, >> >> the := disappeared >> >> try to indent with tabs, here >> >>>> PTXCONF_HOST_SQUASHFS_TOOLS_V3X, 3.4, 4.0) > > I thought the = instead := was needed when a variable is used from > another make file, in this case "PTXCONF_HOST_SQUASHFS_TOOLS_V3X" ?
Right, but the variable comes from the selected_*config. "PTXCONF_HOST_SQUASHFS_TOOLS_V3X" it starts with a PTXCONF_. Cheers, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
-- ptxdist mailing list [email protected]
