Marc Kleine-Budde wrote:
Erwin Rol wrote:
Marc Kleine-Budde wrote:
Erwin Rol wrote:
Is that patch acceptable ?
not yet, see comments inline:
+#
+# Paths and names
+#
+SQUASHFS_TOOLS_VERSION = $(call ptx/ifdef,
the := disappeared
try to indent with tabs, here
PTXCONF_HOST_SQUASHFS_TOOLS_V3X, 3.4, 4.0)
I thought the = instead := was needed when a variable is used from
another make file, in this case "PTXCONF_HOST_SQUASHFS_TOOLS_V3X" ?
Right, but the variable comes from the selected_*config.
"PTXCONF_HOST_SQUASHFS_TOOLS_V3X" it starts with a PTXCONF_.
So the one;
HOST_SQUASHFS_TOOLS_DIR = $(HOST_BUILDDIR)/$(SQUASHFS_TOOLS)
in host-squashfs.make is needed ?
- Erwin
--
ptxdist mailing list
[email protected]