On Mon, Nov 15, 2010 at 12:37:29PM +0100, Alexander Stein wrote: > On some system HOST_SQUASHFS_TOOLS_INSTALL_OPT didn't get set properly > so the image creation part breaks. > --- > I have no idea why this isn't set on 2 machines, while it is working fine > on one machine. > The wrong value was set to: > .../platform-***/packages/host- > while the correct one is > .../platform-***/packages/host-squashfs4.0/sbin > > Any ideas? > > Best regards > Alexander > > PS: There is no SoB, because I don't think such patch goes mainline.
Actually I think it should: HOST_SQUASHFS_TOOLS = $(SQUASHFS_TOOLS) HOST_SQUASHFS_TOOLS_PKGDIR = $(PKGDIR)/host-$(HOST_SQUASHFS_TOOLS) and SQUASHFS_TOOLS is defined in rules/squashfs-tools.make With ":=" this only works if rules/squashfs-tools.make is included before rules/host-squashfs-tools.make. This is not guaranteed. That's why most host-* packages use "=" for their variables. For more details check the make documentation about the differences between "=" and ":=". Michael > rules/host-squashfs-tools.make | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/rules/host-squashfs-tools.make b/rules/host-squashfs-tools.make > index 98e6c2e..af63a28 100644 > --- a/rules/host-squashfs-tools.make > +++ b/rules/host-squashfs-tools.make > @@ -25,6 +25,6 @@ HOST_SQUASHFS_TOOLS_SUBDIR := squashfs-tools > > HOST_SQUASHFS_TOOLS_MAKE_ENV := $(HOST_ENV) > HOST_SQUASHFS_TOOLS_MAKE_PAR := NO > -HOST_SQUASHFS_TOOLS_INSTALL_OPT := install > INSTALL_DIR="$(HOST_SQUASHFS_TOOLS_PKGDIR)/sbin" > +HOST_SQUASHFS_TOOLS_INSTALL_OPT = install > INSTALL_DIR="$(HOST_SQUASHFS_TOOLS_PKGDIR)/sbin" > > # vim: syntax=make > -- > 1.7.2.2 > > > -- > ptxdist mailing list > [email protected] > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list [email protected]
