Hi,

I've seen the whole series, but I'm rather busy, and this requires a bit
more thinking. So it may take a while before we get everything in.

On Mon, Mar 19, 2012 at 10:14:44PM +0100, Remy Bohmer wrote:
> The ARCH_X86_64 architecture is added as subtype of ARCH_X86 since it
> basically is the same architecture, and a mix of both architectures
> will be required to allow multilib support in a later commit.
> 
> Signed-off-by: Remy Bohmer <[email protected]>
> ---
>  v2: no changes since v1
> 
>  platforms/architecture.in |   15 +++++++++++++--
>  1 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/platforms/architecture.in b/platforms/architecture.in
> index ed36e8a..f00108e 100644
> --- a/platforms/architecture.in
> +++ b/platforms/architecture.in
> @@ -181,6 +181,16 @@ choice
>  
>  endchoice
>  
> +if ARCH_X86
> +#
> +# 32/64 bits platform
> +#
> +config ARCH_X86_64
> +     bool "64 bit architecture"
> +     help
> +       Select this option if you build for a 64 bit architecture.
> +
> +endif

Have you considered adding ARCH_X86_32 as well (in a switch)? I think some
if our current "ifdef ARCH_X86" are really for 32bit only, so an option
would probably be useful.

Michael

>  
>  #
>  # endianess
> @@ -263,7 +273,7 @@ config HAS_MMU
>  config SIZEOF_LONG_DOUBLE
>       string
>       default "12" if ARCH_X86
> -#    default "16" if ARCH_X86_64
> +     default "16" if ARCH_X86_64
>       default "8"
>       # FIXME: add more values
>  
> @@ -277,7 +287,8 @@ config ARCH_STRING
>       default "avr32"                 if ARCH_AVR32
>       default "alpha"                 if ARCH_ALPHA
>       default "blackfin"              if ARCH_BLACKFIN
> -     default "i386"                  if ARCH_X86
> +     default "i386"                  if ARCH_X86 && !ARCH_X86_64
> +     default "x86_64"                if ARCH_X86 && ARCH_X86_64
>       default "i386"                  if ARCH_MINGW
>       default "m68k"                  if ARCH_M68K
>       default "ppc"                   if ARCH_PPC
> -- 
> 1.7.5.4
> 
> 
> -- 
> ptxdist mailing list
> [email protected]
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
[email protected]

Reply via email to