Hello, git format-patch helps you to add a version to your patch. In this case -v2 would have been nice. This makes it easier for Michael to pick up the right patch.
On Thu, Apr 07, 2016 at 12:10:04PM +0200, Gavin Schenk wrote: > Supports ipv4 and ipv6 and both options can be selected in menuconfig > IPTABLES_IPV6_SYSTEMD_UNIT and IPTABLES_IPV4_SYSTEMD_UNIT > > If you select IPTABLES_IPV4_SYSTEMD_UNIT a systemd unit is started on > multiuser.target that set the iptable rules from file /etc/iptables/rules.v4. > If you select IPTABLES_IPV6_SYSTEMD_UNIT a systemd unit is started on > multiuser.target that set the iptable rules from the file > /etc/iptables/rules.v6. > You have to provide this files. Both files can easily be generated with the > utils iptables-save ip6tables-save from the iptables package. Please wrap lines before column 76. > > e.g: Generating a rulefile, that drops port 5000 on interface eth0 ipv4 > 1.) iptables -A INPUT -i eth0 -p TCP --dport 5000 -j DROP > 2.) iptables-save > /etc/iptables/rules.v4 > > The basic idea was taken from https://github.com/gronke/systemd-iptables > written by Stefan Grönke in 2015. You need to add a S-o-B line. Other than that the patch looks good (which doesn't imply that Michael has nothing to criticize). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ ptxdist mailing list [email protected]
