Hi, On Mon, Apr 11, 2016 at 12:08:51PM +0000, Schenk, Gavin wrote: > > > +for table in $(</proc/net/ip6_tables_names) > > > > This does not work with a busybox /bin/sh. I think that's bashism. > > > > This should work: > > > > for table in $(cat /proc/net/ip6_tables_names); do ... > > > > Note: It doesn't fail! The list is always empty! > > Grrrr Uwe told me about the tool checkbashism last week, but I forgot to use > it here :(. > I tested the implementation with cat and it works!
:-) > > > + @$(call install_link, iptables, ../ip6tables.service, > > > +/lib/systemd/system/multi-user.target.wants/ip6tables.service) > > > > @$(call install_link, iptables, ../ip6tables.service, \ > > /lib/systemd/system/multi- > > user.target.wants/ip6tables.service) > > > > Break like this. > > Can you please tell me about the limits of columns in makefiles, or where I > can read about it? > In some Makefiles more than 80 columns are used. Is there a kind of hard- and > soft-limit :)? > > I´ ll send a new patch after testing the changes The soft limit is 80 columns. If making the lines a bit longer makes it more readable, then that's ok too. I'm sure there are quite a few old rules that don't match my requirements. If I do non trivial changes to a rule, then I usually clean it up as well. But I don't have the time to cleanup all rules. If you need examples then look for rules I created or modified in the last year or so. Those typically match what I think a rule should look like... Regards, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list [email protected]
