Hi,

On Fri, Oct 05, 2018 at 11:25:45AM +0200, Guillermo Rodriguez wrote:
> Open source cross platform flash program for the STM32 ARM
> microcontrollers using the built-in ST serial bootloader over UART
> or I2C.
> 
> Signed-off-by: Guillermo Rodriguez <[email protected]>
> ---
>  rules/stm32flash.in   |  9 ++++++++
>  rules/stm32flash.make | 57 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 66 insertions(+)
>  create mode 100644 rules/stm32flash.in
>  create mode 100644 rules/stm32flash.make
> 
> diff --git a/rules/stm32flash.in b/rules/stm32flash.in
> new file mode 100644
> index 0000000..877eed3
> --- /dev/null
> +++ b/rules/stm32flash.in
> @@ -0,0 +1,9 @@
> +## SECTION=shell_and_console
> +
> +config STM32FLASH
> +     tristate
> +     prompt "stm32flash"
> +     help
> +       Open source cross platform flash program for the STM32 ARM
> +       microcontrollers using the built-in ST serial bootloader over UART
> +       or I2C.
> diff --git a/rules/stm32flash.make b/rules/stm32flash.make
> new file mode 100644
> index 0000000..975d02e
> --- /dev/null
> +++ b/rules/stm32flash.make
> @@ -0,0 +1,57 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2018 by Guillermo Rodriguez <[email protected]>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_STM32FLASH) += stm32flash
> +
> +#
> +# Paths and names
> +#
> +STM32FLASH_VERSION   := 0.5
> +STM32FLASH_SUFFIX    := tar.gz
> +STM32FLASH_MD5               := 40f673502949f3bb655d2bcc539d7b6a
> +STM32FLASH           := stm32flash-$(STM32FLASH_VERSION)
> +STM32FLASH_URL               := 
> https://sourceforge.net/projects/stm32flash/files/$(STM32FLASH).$(STM32FLASH_SUFFIX)/download

Better use $(call ptx/mirror, SF, ...) here to get a list of SourceForge
mirrors. Have a look at other packages for how to use it.

> +STM32FLASH_DIR               := $(BUILDDIR)/$(STM32FLASH)
> +STM32FLASH_SOURCE    := $(SRCDIR)/$(STM32FLASH).$(STM32FLASH_SUFFIX)
> +STM32FLASH_LICENSE   := GPLv2
> +
> +
> +# 
> ----------------------------------------------------------------------------
> +# Prepare
> +# 
> ----------------------------------------------------------------------------
> +
> +STM32FLASH_CONF_TOOL := NO
> +STM32FLASH_MAKE_ENV  := $(CROSS_ENV)
> +STM32FLASH_INSTALL_OPT       := PREFIX=/usr install

For readability, keep these options on a single line each:

STM32FLASH_INSTALL_OPT       := \
        PREFIX=/usr \
        install

Also most packages keep *_INSTALL_* variables under the Install section
header, and *_MAKE_* variables under the "Compile" section header. I
would suggest to do it here too to get a unified look over package
rules.

> +
> +# 
> ----------------------------------------------------------------------------
> +# Target-Install
> +# 
> ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/stm32flash.targetinstall:
> +     @$(call targetinfo)
> +
> +     @$(call install_init, stm32flash)
> +     @$(call install_fixup, stm32flash, PRIORITY,optional)
> +     @$(call install_fixup, stm32flash, SECTION,base)
> +     @$(call install_fixup, stm32flash, AUTHOR,"Guillermo Rodriguez 
> <[email protected]>")
> +     @$(call install_fixup, stm32flash, DESCRIPTION,missing)
> +
> +     @$(call install_copy, stm32flash, 0, 0, 0755, -, /usr/bin/stm32flash)
> +
> +     @$(call install_finish, stm32flash)
> +     
> +     @$(call touch)
> +

While you're at it, no need for a double blank line here :)

 - Roland

> +
> +# vim: syntax=make
> -- 
> 2.5.4 (Apple Git-61)
> 
> 
> _______________________________________________
> ptxdist mailing list
> [email protected]

-- 
Roland Hieber                     | [email protected]     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
[email protected]

Reply via email to