On Tue, 18 Feb 2020 10:02:57 +0100, Guillermo Rodriguez Garcia wrote: > El mar., 18 feb. 2020 a las 8:36, Michael Olbrich > (<[email protected]>) escribió: > > > > On Mon, Feb 17, 2020 at 05:33:57PM +0100, Guillermo Rodriguez Garcia wrote: > > > > > El lun., 17 feb. 2020 a las 17:26, Michael Tretter > > > (<[email protected]>) escribió: > > > > > > > > On Wed, 12 Feb 2020 17:40:33 +0100, Ahmad Fatoum wrote: > > > > > Trusted Firmware-A (TF-A) is a reference implementation of secure > > > > > world > > > > > software for Arm A-Profile architectures (Armv8-A and Armv7-A). > > > > > > > > I successfully built the TF-A BL31 for the ZynqMP using this rule. > > > > > > > > However, I saw that the TF-A build uses the current git commitish for > > > > BUILD_STRING, which will be written into the binary. If I build the > > > > TF-A with this rule, this ends up to be the commitish of the BSP. I'm > > > > not sure if I actually want this, but I don't know what to put there > > > > instead. > > > > > > Since we finally agreed to keep TF_A_EXTRA_ARGS in the final TF-A rule > > > files, you can actually set BUILD_STRING to anything you want. Just > > > include BUILD_STRING=whatever in the TF_A_EXTRA_ARGS parameter. > > > > There should always be a default BUILD_STRING that does not depend on the > > BSP commit-ish. $(TF_A_VERSION) probably. > > OK, then we could add this to the .make file: > > TF_A_MAKE_OPT := \ > CROSS_COMPILE=$(BOOTLOADER_CROSS_COMPILE) \ > HOSTCC=$(HOSTCC) \ > PLAT=$(PTXCONF_TF_A_PLATFORM) \ > ARCH=$(PTXCONF_TF_A_ARCH_STRING) \ > ARM_ARCH_MAJOR=$(PTXCONF_TF_A_ARM_ARCH_MAJOR) \ > BUILD_STRING=$(PTXCONF_TF_A_VERSION) \
The version string that is printed during the boot will then be something like "v2.2(Release):v2.2". The first version is the hard coded version in the makefile and the second is the git commitish that was used to build the tf-a. Seems OK to me. Michael > $(call remove_quotes,$(PTXCONF_TF_A_EXTRA_ARGS)) \ > all > > BUILD_STRING can still be overriden in TF_A_EXTRA_ARGS if needed. > > Guillermo > > _______________________________________________ > ptxdist mailing list > [email protected] _______________________________________________ ptxdist mailing list [email protected]
