Moin, On Fri, Jun 17, 2022 at 12:27:50PM +0200, Michael Olbrich wrote: > On Fri, Jun 17, 2022 at 11:47:19AM +0200, Enrico Jörns wrote: > > Am Freitag, dem 17.06.2022 um 08:28 +0200 schrieb Michael Olbrich: > > > On Wed, Jun 15, 2022 at 04:22:14PM +0200, Enrico Jorns wrote: > > > > Enable it by default so that default installation can benefit from this. > > > > Can be deactivated for saving space or for deactivating network > > > > functionality. > > > > Web server must support HTTP range requests for this and NBD support > > > > must be enabled in kernel. > > > > > > > > Signed-off-by: Enrico Jorns <[email protected]> > > > > --- > > > > rules/rauc.in | 11 +++++++++++ > > > > rules/rauc.make | 1 + > > > > 2 files changed, 12 insertions(+) > > > > > > > > diff --git a/rules/rauc.in b/rules/rauc.in > > > > index aee162b83..832967b44 100644 > > > > --- a/rules/rauc.in > > > > +++ b/rules/rauc.in > > > > @@ -13,6 +13,7 @@ menuconfig RAUC > > > > select BUSYBOX_FEATURE_SEAMLESS_GZ if BUSYBOX_TAR > > > > select DBUS if RAUC_SERVICE > > > > select LIBCURL if RAUC_NETWORK > > > > + select LIBNL3 if RAUC_STREAMING > > > > select JSON_GLIB if RAUC_JSON > > > > select UTIL_LINUX_NG_LIBFDISK if RAUC_GPT > > > > select SQUASHFS_TOOLS if RUNTIME > > > > @@ -44,6 +45,16 @@ config RAUC_NETWORK > > > > Note that network is primarily designed to be used for RAUC'S > > > > casync > > > > capabilities, not for fetching full bundles. > > > > > > > > +config RAUC_STREAMING > > > > + bool > > > > + prompt "Enable streaming support" > > > > + default y > > > > > > Why 'default y'? I think most users won't need this. > > > > I am not convinced that streaming is not required for most users. I guess > > that > > being able to download bundles form HTTP directly is a use case that is > > more and > > more common. With network and streaming enabled, one can download bundles > > only > > externally or install from USB sticks etc. > > > > In Yocto we have this enabled by default, too. If it's ptxdist's philosophy > > to > > ship as little features as possible by default (i.e. focus on small size), > > we > > can also make this default n. > > The thing is, nobody changes the defaults unless they notice something is > not working as expected. And enabling things in PTXdist is easy.
Despite how the default should be if one enables RAUC the first time, how does this behave when upgrading? I mean if I have RAUC enabled and running with some method, then this update comes along. Does ptxdist enable that option on migrate? I yes I would opt against making this default y, because that would just add a then unused feature. A > > How does this work anyways? If I call 'rauc install <some-url>', will this > use streaming implicitly or does it require an explicit option? > > How about 'default RAUC_NETWORK'? This way those that use networking also > get streaming by default. > > I can do a fixup here if this makes sense. > > Michael > > > > > > + select RAUC_NETWORK > > > > + help > > > > + Enables built-in HTTP(S) streaming support that allows RAUC to > > > > + access remote bundles via http/https and write images without > > > > the > > > > + need for intermediate storage on the target. > > > > + > > > > config RAUC_JSON > > > > bool > > > > prompt "JSON support" > > > > diff --git a/rules/rauc.make b/rules/rauc.make > > > > index 46d196bed..820583e59 100644 > > > > --- a/rules/rauc.make > > > > +++ b/rules/rauc.make > > > > @@ -43,6 +43,7 @@ RAUC_CONF_OPT := \ > > > > --disable-valgrind \ > > > > --$(call ptx/endis,PTXCONF_RAUC_SERVICE)-service \ > > > > --$(call ptx/endis,PTXCONF_RAUC_NETWORK)-network \ > > > > + --$(call ptx/endis,PTXCONF_RAUC_STREAMING)-streaming \ > > > > --$(call ptx/endis,PTXCONF_RAUC_JSON)-json \ > > > > --$(call ptx/endis,PTXCONF_RAUC_GPT)-gpt \ > > > > --with-systemdunitdir=/usr/lib/systemd/system \ > > > > -- > > > > 2.30.2 > > > > > > > > > > > > > > > > > > > -- > > Pengutronix e.K. | Enrico Jörns | > > Embedded Linux Consulting & Support | https://www.pengutronix.de/ | > > Steuerwalder Str. 21 | Phone: +49-5121-206917-180 | > > 31137 Hildesheim, Germany | Fax: +49-5121-206917-9 | > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- /"\ ASCII RIBBON | »With the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.« / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
signature.asc
Description: PGP signature
