I don't understand the details of this PR. Is there a dev out there who can look at this?
@suttner, Thank you for the PR. I'm not sure what testing needs to be done as part of the review. Would you be willing to write a test plan that a reviewer could use? We usually write them as pulp smash issues so they could become part of the nightly integration tests of Pulp. If so, you can write one here [0], and you can see some examples there too. I think having that will greatly speed up getting this accepted. [0]: https://github.com/PulpQE/pulp-smash/issues Thanks, Brian On Mon, Mar 27, 2017 at 4:36 PM, Mihai Ibanescu <[email protected]> wrote: > Thanks for clarifying, I hadn't noticed the "handlers" portion of the path. > > On Mon, Mar 27, 2017 at 4:32 PM, Bernhard Suttner <[email protected]> wrote: > >> Hi Mihai, >> >> the change is on the client side to use zypper instead of yum to install >> / uninstall / update packages and package groups. Zypper is the package >> manager on SUSE based linux distribution (pretty good as it is written in >> C++ and therefore really fast) >> >> I guess, you are also planning to integrate dnf and use it instead of >> yum. Therefore, I think you will need to have a plugin structure to decide, >> which package manager to use on the various systems. >> >> Best regards, >> Bernhard >> >> ------------------------------ >> *Von: *"Mihai Ibanescu" <[email protected]> >> *An: *"suttner" <[email protected]> >> *CC: *"Pulp-dev" <[email protected]> >> *Gesendet: *Montag, 27. März 2017 14:56:00 >> *Betreff: *Re: [Pulp-dev] Use zypper on SUSE instead of yum (pull >> request) >> >> Bernhard, >> It may have been clear for others, but I need to clarify this for myself. >> >> Is the intention of the patch to allow pulp to run on a SuSE system? >> >> Or is it to make Pulp repositories that are properly understood by zypper? >> >> The title of the PR seems to imply the latter, while the patch seems to >> implement the former. >> >> Thank you! >> Mihai >> >> >> On Mon, Mar 27, 2017 at 3:12 AM, Bernhard Suttner <[email protected]> >> wrote: >> >>> .... just spend some minutes and fixed the issues found by flake8. See >>> pull request: https://github.com/pulp/pulp_rpm/pull/1041 >>> >>> >>> ------------------------------ >>> *Von: *"Bernhard Suttner" <[email protected]> >>> *An: *[email protected] >>> *Gesendet: *Sonntag, 26. März 2017 16:29:13 >>> *Betreff: *[Pulp-dev] Use zypper on SUSE instead of yum (pull request) >>> >>> >>> Hi, >>> >>> I have send a pull request to pulp_rpm regarding using zypper instead of >>> yum on SUSE based distributions. I know, that some (OK, a lot) of tests >>> failed. >>> >>> Would you merge this change if I would fix the issue? Just want to make >>> sure, if there is anything else I should consider. Maybe there are other >>> integrations planned like dnf and you want to re-structure the code in this >>> part - e.g. with a configurable plugin structure. >>> >>> Best regards, >>> Bernhard >>> >>> ATIX Informationstechnologie und Consulting AG >>> >>> _______________________________________________ >>> Pulp-dev mailing list >>> [email protected] >>> https://www.redhat.com/mailman/listinfo/pulp-dev >>> >>> >>> _______________________________________________ >>> Pulp-dev mailing list >>> [email protected] >>> https://www.redhat.com/mailman/listinfo/pulp-dev >>> >>> >> > > _______________________________________________ > Pulp-dev mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/pulp-dev > >
_______________________________________________ Pulp-dev mailing list [email protected] https://www.redhat.com/mailman/listinfo/pulp-dev
