I think we should (if possible) change our redmine automation to: closes https://pulp.plan.io/issues/1234
I like this because there is no ambiguity and it will prevent us from having to also add the href to the PR as a comment. On Mon, Jan 8, 2018 at 1:17 PM, Daniel Alley <[email protected]> wrote: > Even if we don't change this, It's something we should keep in mind since > our PR #s are currently in a spot where they may frequently overlap with > issue #s. At some point they'll diverge again and it won't be so much of > an issue, but currently it is. > > I don't know precisely how the redmine integration works, but perhaps we > could change the syntax to "closes redmine #xxxx"? > > On Mon, Jan 8, 2018 at 10:41 AM, David Davis <[email protected]> > wrote: > >> Today, I had a PR[0] that was accidentally closed by another PR[1]. The >> issue is that the format we’re using attach our commits to redmine issues >> (e.g. 'fixes #1234’) is the exact same format as what Github uses[2]. >> >> I’m wondering if we should change our format. I hate to do so but at the >> same time, I worry about PRs getting closed by accident in the future. >> Thoughts? >> >> [0] https://github.com/pulp/pulp/pull/3245 >> <https://github.com/pulp/pulp/pull/3245>[1] https://github.com/pulp/pu >> lp/pull/3252 >> [2] https://help.github.com/articles/closing-issues-using-keywords/ >> >> David >> >> _______________________________________________ >> Pulp-dev mailing list >> [email protected] >> https://www.redhat.com/mailman/listinfo/pulp-dev >> >> > > _______________________________________________ > Pulp-dev mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/pulp-dev > >
_______________________________________________ Pulp-dev mailing list [email protected] https://www.redhat.com/mailman/listinfo/pulp-dev
