+1 to removing it On Tue, Dec 4, 2018 at 8:34 AM Austin Macdonald <amacd...@redhat.com> wrote:
> +1, nice catch Daniel. > > On Tue, Dec 4, 2018, 7:14 AM David Davis <davidda...@redhat.com wrote: > >> Big +1. This seems like something we could add later on at any time when >> we need it. Hopefully we can get Katello and our users involved in sussing >> out the requirements for how this field should work too. >> >> David >> >> >> On Mon, Dec 3, 2018 at 11:34 PM Daniel Alley <dal...@redhat.com> wrote: >> >>> *Background:* >>> >>> "Notes" are a generic key value store where data can be attached to >>> repositories and content and publications and so forth. The eventual plan >>> is to use this to enable adding tags to those sorts of objects, which is >>> important for Katello. >>> >>> Most of the code for this is located in pulp/app/models/generic.py >>> >>> *Motivation:* >>> >>> "Notes" have been in Pulp 3 for a very very long time and are completely >>> unchanged for the last 12 months (the git history doesn't go back further >>> because the file was moved). The data model behind it is extremely complex >>> and while we have a few unit tests around it, we have no functional tests >>> for it whatsoever, and (to my knowledge) we haven't been using/exercising >>> this functionality manually in a meaningful way (if at all). I could be >>> wrong here, but I haven't seen it discussed or any issues related to it >>> filed in quite some time. >>> >>> *Proposal:* >>> >>> We should pull out all of the "notes" code (models/generic.py + the >>> fields on the aforementioned models) until we've had a chance to properly >>> evaluate our needs and whether the current design fits them. >>> _______________________________________________ >>> Pulp-dev mailing list >>> Pulp-dev@redhat.com >>> https://www.redhat.com/mailman/listinfo/pulp-dev >>> >> _______________________________________________ >> Pulp-dev mailing list >> Pulp-dev@redhat.com >> https://www.redhat.com/mailman/listinfo/pulp-dev >> > _______________________________________________ > Pulp-dev mailing list > Pulp-dev@redhat.com > https://www.redhat.com/mailman/listinfo/pulp-dev >
_______________________________________________ Pulp-dev mailing list Pulp-dev@redhat.com https://www.redhat.com/mailman/listinfo/pulp-dev