+1

Dana Walker

Associate Software Engineer

Red Hat

<https://www.redhat.com>
<https://red.ht/sig>


On Tue, Dec 4, 2018 at 1:52 PM Tatiana Tereshchenko <ttere...@redhat.com>
wrote:

> +1
>
> On Tue, Dec 4, 2018 at 4:49 PM Brian Bouterse <bbout...@redhat.com> wrote:
>
>> +1. Ty for bringing this up @dalley
>>
>> On Tue, Dec 4, 2018 at 10:47 AM Jeff Ortel <jor...@redhat.com> wrote:
>>
>>> no objection
>>>
>>> On 12/3/18 10:32 PM, Daniel Alley wrote:
>>>
>>> *Background:*
>>>
>>> "Notes" are a generic key value store where data can be attached to
>>> repositories and content and publications and so forth.  The eventual plan
>>> is to use this to enable adding tags to those sorts of objects, which is
>>> important for Katello.
>>>
>>> Most of the code for this is located in pulp/app/models/generic.py
>>>
>>> *Motivation:*
>>>
>>> "Notes" have been in Pulp 3 for a very very long time and are completely
>>> unchanged for the last 12 months (the git history doesn't go back further
>>> because the file was moved).  The data model behind it is extremely complex
>>> and while we have a few unit tests around it, we have no functional tests
>>> for it whatsoever, and (to my knowledge) we haven't been using/exercising
>>> this functionality manually in a meaningful way (if at all).  I could be
>>> wrong here, but I haven't seen it discussed  or any issues related to it
>>> filed in quite some time.
>>>
>>> *Proposal:*
>>>
>>> We should pull out all of the "notes" code (models/generic.py + the
>>> fields on the aforementioned models) until we've had a chance to properly
>>> evaluate our needs and whether the current design fits them.
>>>
>>> _______________________________________________
>>> Pulp-dev mailing 
>>> listPulp-dev@redhat.comhttps://www.redhat.com/mailman/listinfo/pulp-dev
>>>
>>>
>>> _______________________________________________
>>> Pulp-dev mailing list
>>> Pulp-dev@redhat.com
>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>
>> _______________________________________________
>> Pulp-dev mailing list
>> Pulp-dev@redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev@redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
_______________________________________________
Pulp-dev mailing list
Pulp-dev@redhat.com
https://www.redhat.com/mailman/listinfo/pulp-dev

Reply via email to