src/modules/x11/module-x11-bell.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit ce4b3603aea1b4e83ce6324b81abfe75f2bf78ec
Author: Tanu Kaskinen <ta...@iki.fi>
Date: Thu Nov 10 13:22:04 2016 +0200
x11-bell: ignore volume from X11
X11 has its own bell volume setting, controlled with the "xset b"
command. If we use that volume, then the "System Sounds" slider in
pavucontrol doesn't affect the x11-bell sample volume, which in my
opinion is a bad thing. Ignoring the volume suggestion from X11 allows
module-stream-restore to apply the "event" role volume.
diff --git a/src/modules/x11/module-x11-bell.c
b/src/modules/x11/module-x11-bell.c
index 6c9f580..7b2be57 100644
--- a/src/modules/x11/module-x11-bell.c
+++ b/src/modules/x11/module-x11-bell.c
@@ -76,7 +76,10 @@ static int x11_event_cb(pa_x11_wrapper *w, XEvent *e, void
*userdata) {
bne = (XkbBellNotifyEvent*) e;
- if (pa_scache_play_item_by_name(u->core, u->scache_item, u->sink_name,
((pa_volume_t) bne->percent*PA_VOLUME_NORM)/100U, NULL, NULL) < 0) {
+ /* We could use bne->percent to set the volume, but then the "event" role
+ * volume wouldn't have effect. It's better to ignore the volume suggestion
+ * from X11. */
+ if (pa_scache_play_item_by_name(u->core, u->scache_item, u->sink_name,
PA_VOLUME_INVALID, NULL, NULL) < 0) {
pa_log_info("Ringing bell failed, reverting to X11 device bell.");
XkbForceDeviceBell(pa_x11_wrapper_get_display(w), bne->device,
bne->bell_class, bne->bell_id, bne->percent);
}
_______________________________________________
pulseaudio-commits mailing list
pulseaudio-commits@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-commits
