src/modules/raop/raop-sink.c | 7 +++++++
1 file changed, 7 insertions(+)
New commits:
commit 58fb7b734d17589bef33b41a5453c8be4dc87169
Author: Tanu Kaskinen <ta...@iki.fi>
Date: Fri Jul 28 04:07:49 2017 +0300
raop: silence a Coverity complaint
CID: 1398155
diff --git a/src/modules/raop/raop-sink.c b/src/modules/raop/raop-sink.c
index e5d219e8..4d13927f 100644
--- a/src/modules/raop/raop-sink.c
+++ b/src/modules/raop/raop-sink.c
@@ -391,6 +391,13 @@ static void thread_func(void *userdata) {
if (!pa_raop_client_can_stream(u->raop))
continue;
+ /* This assertion is meant to silence a complaint from Coverity about
+ * pollfd being possibly NULL when we access it later. That's a false
+ * positive, because we check pa_raop_client_can_stream() above, and if
+ * that returns true, it means that the connection is up, and when the
+ * connection is up, pollfd will be non-NULL. */
+ pa_assert(pollfd);
+
if (u->memchunk.length <= 0) {
if (u->memchunk.memblock)
pa_memblock_unref(u->memchunk.memblock);
_______________________________________________
pulseaudio-commits mailing list
pulseaudio-commits@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-commits
