On 2011-07-03 15:00, Colin Guthrie wrote:
'Twas brillig, and David Henningsson at 01/07/11 14:03 did gyre and gimble:
I wonder if we're better off with the attached patch. I've seen more
than one system where the volume control named "Front" is a part of
audio path for headphones. The attached patch would be somewhat of a
compromise: While we don't merge it into the path, as that would be
regressing machines where "Front" isn't a part of the audio path, it
would still enable sound on these machines. The question is if "Front"
is turning on some output it shouldn't on some machines, but I think it
wouldn't: this should (for all common systems I can think of) be fixed
through the driver's auto-mute anyway.
Seems like a reasonable compromise to me, but does anyone else have any
opinions on this? Or perhaps any cases where regressions could be caused?
(see my latest comment on the path_set_condense() method which checks
volume use for OFF which could actually get in the way here!!)
The other option would be to quirk every single machine that has this
problem to a separate udev rule -> profile-set -> path .conf file.
What do you think?
Yeah I really don't like that option. If we do need some quirks here I'd
much rather see them implemented in a more fine grained way than with
udev rules... as it's a bit of blunt object. But ideally avoid it
altogether.
Col
Ok, here's a patch properly formatted for inclusion.
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
>From 66eee7184890aa1cca1292977fe581c457befe85 Mon Sep 17 00:00:00 2001
From: David Henningsson <[email protected]>
Date: Mon, 4 Jul 2011 10:12:17 +0200
Subject: [PATCH] alsa-mixer: Set "Front" control to 0 dB on headphone path
I've seen more than one system where the volume control named
"Front" is a part of audio path for headphones. This is somewhat
of a compromise: While we don't merge it into the path, as that
would be regressing machines where "Front" isn't a part of the
audio path, it would still enable sound on these machines.
BugLink: http://bugs.launchpad.net/bugs/804178
Signed-off-by: David Henningsson <[email protected]>
---
.../mixer/paths/analog-output-headphones-2.conf | 5 +++--
.../alsa/mixer/paths/analog-output-headphones.conf | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/modules/alsa/mixer/paths/analog-output-headphones-2.conf b/src/modules/alsa/mixer/paths/analog-output-headphones-2.conf
index e47543f..284713b 100644
--- a/src/modules/alsa/mixer/paths/analog-output-headphones-2.conf
+++ b/src/modules/alsa/mixer/paths/analog-output-headphones-2.conf
@@ -60,9 +60,10 @@ volume = off
switch = off
volume = off
+; On some machines Front is actually a part of the Headphone path
[Element Front]
-switch = off
-volume = off
+switch = mute
+volume = zero
[Element Rear]
switch = off
diff --git a/src/modules/alsa/mixer/paths/analog-output-headphones.conf b/src/modules/alsa/mixer/paths/analog-output-headphones.conf
index 1d7bb0b..7062918 100644
--- a/src/modules/alsa/mixer/paths/analog-output-headphones.conf
+++ b/src/modules/alsa/mixer/paths/analog-output-headphones.conf
@@ -60,9 +60,10 @@ volume = off
switch = off
volume = off
+; On some machines Front is actually a part of the Headphone path
[Element Front]
-switch = off
-volume = off
+switch = mute
+volume = zero
[Element Rear]
switch = off
--
1.7.4.1
_______________________________________________
pulseaudio-discuss mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
