On 2011-08-03 05:41, Tanu Kaskinen wrote:
On Tue, 2011-08-02 at 14:34 +0200, David Henningsson wrote:
This patch introduces some extra protocol information, so protocol
version is bumped. This functionality is primarily needed to solve
a long standing issue in alsa-plugins, which should ignore underruns
if and only if it is obsolete, i e, if more data has been written to
the pipe in the meantime (which will automatically end the underrun).

Looks good to me. Documentation in PROTOCOL is missing, though.


Ah! I knew I had seen such a file somewhere. Here's a trivial patch.

--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
>From bb20cfcb471c9db7b9ffca5c832babd54a0e6a89 Mon Sep 17 00:00:00 2001
From: David Henningsson <[email protected]>
Date: Thu, 4 Aug 2011 10:33:54 +0200
Subject: [PATCH] Document PA_COMMAND_UNDERFLOW protocol change

Signed-off-by: David Henningsson <[email protected]>
---
 PROTOCOL |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/PROTOCOL b/PROTOCOL
index 6b999af..2773ca5 100644
--- a/PROTOCOL
+++ b/PROTOCOL
@@ -271,3 +271,9 @@ PA_COMMAND_GET_SOURCE_OUTPUT_INFO_LIST)
     bool mute
     bool has_volume
     bool volume_writable
+
+## v23, implemented by >= 1.0
+
+New field in PA_COMMAND_UNDERFLOW:
+
+    int64_t index
-- 
1.7.4.1

_______________________________________________
pulseaudio-discuss mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Reply via email to