On Wed, Aug 10, 2011 at 11:42:03PM +0800, Maarten Bosmans wrote: > 2011/8/10 Lu Guanqun <[email protected]>: > > According to the principle of DRY (don't repeat yourself), remove the code > > for > > setting thread name in thread-posix.c. > > > > Signed-off-by: Lu Guanqun <[email protected]> > > --- > > src/pulsecore/thread-posix.c | 20 ++++++++++---------- > > 1 files changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/src/pulsecore/thread-posix.c b/src/pulsecore/thread-posix.c > > index 3f4ae5c..81ae98d 100644 > > --- a/src/pulsecore/thread-posix.c > > +++ b/src/pulsecore/thread-posix.c > > @@ -65,15 +65,19 @@ static void thread_free_cb(void *p) { > > > > PA_STATIC_TLS_DECLARE(current_thread, thread_free_cb); > > > > +static void pa_thread_set_name_raw(const char *name) { > > We generally do not prefix internal functions with pa_.\ > See http://pulseaudio.org/wiki/CodingStyle, #7.
Thanks for pointing this out. Will resend it. -- guanqun _______________________________________________ pulseaudio-discuss mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
