On 11/16/2011 12:49 PM, Maarten Bosmans wrote:
I'm looking for some guidance on how to solve
https://bugs.freedesktop.org/show_bug.cgi?id=41539.
The problem is that pulsecore/pstream.c (in libpulsecommon) includes
pulsecore/core-scache.h (which is itself in and includes from
libpulsecore), this is wrong. Apparantly it causes real trouble on
Solaris.
The header core-scache.h is only included to make the
PA_SCACHE_ENTRY_SIZE_MAX preprocessor symbol available.
And
#define FRAME_SIZE_MAX_ALLOW PA_SCACHE_ENTRY_SIZE_MAX /* allow uploading
a single sample in one frame at max */
There are several solutions possible.
- Move the #define to a file in libpulsecommon. This is the solution
proposed in the patch attached to the bug. However, I don't like the
proposed new location in memchunk.h, because it is quite unrelated to
scache functionality.
How about turning this around:
#define PA_FRAME_SIZE_MAX_ALLOW 1024*1024*16 in pstream.h (or somewhere
else in libpulsecommon)
and
#define PA_SCACHE_ENTRY_SIZE_MAX PA_FRAME_SIZE_MAX_ALLOW
in pulsecore?
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
_______________________________________________
pulseaudio-discuss mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
