On 11/26/2011 04:08 PM, Tanu Kaskinen wrote:
On Fri, 2011-11-25 at 15:16 +0100, David Henningsson wrote:
...so what's up with them? It feels like things have stalled a bit? Are
we waiting for Tanu to finish reviewing the last patch? Or what are we
blocking on?
Maybe I'm just impatient :-)
Tanu seemed to be ok (as of yesterday's IRC discussion) with merging the
five first patches, so maybe consider doing that now?
Done,
\o/
with the following tweaks:
- Added an assertion to pa_device_port_hashmap_free().
For the record, I just want to say that I did not change this not
because I chose to ignore your comment, but because I think this is
error prone behaviour for destructors, and I believe Colin agrees with
me [1]. But maybe the consistency argument weighs heavier. And actually,
there is no "if (c->ports)" in pa_card_free, is this intentional?
- Fixed a compilation issue in alsa-mixer.c. When the pa_core parameter
was added to pa_device_port_new(), the calling code was not updated.
Aha, maybe this was fixed up in patch 6/6 (I did test that my code
compiled before I submitted it).
--
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
[1]
http://lists.freedesktop.org/archives/pulseaudio-discuss/2011-November/012089.html
_______________________________________________
pulseaudio-discuss mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
