'Twas brillig, and David Henningsson at 04/12/11 16:54 did gyre and gimble: >> + * Some configuration files may contain a Property List section, which >> + * is a bit special. Normally all accepted lvalues must be predefined >> + * in the pa_config_item table, but in the Property List section the >> + * pa_config_item table is ignored, and all lvalues are accepted (as >> + * long as they are valid proplist keys). If the proplist pointer is >> + * non-NULL, the parser will parse any section named "Property List" as >> + * properties, and those properties will be merged into the given >> + * proplist. If proplist is NULL, then sections named "Property List" >> + * are not allowed at all in the configuration file. >> + */ > > Now that I think of it, [Properties] is probably an even better section > name - what do you think?
>From a purely cosmetic POV I'd prefer [Properties] (primarily because it's just one word). I thought this when I first read the patches but for some reason got stuck on calling them "Proplist" or "Proplists" or similar and didn't like that name.... I completely failed to think of the work "Properties"... *sigh*. Anyway, other than that very minor change, I think this makes sense and I've had a (quick) read over the diffs and don't spot anything obviously wrong. Cheers Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/ _______________________________________________ pulseaudio-discuss mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
