Hi all, This is Deng Zhenrong from Shanghai China, I've already used Linux as my main desktop for several years. Now I would like to express my interests in applying pulseaudio's projects for this year's GSoC in this mail.
Glancing through the ideas, I find I'm interested in several few already. :) But I'd like to focus on one thing which is test/log facilities for now. I'm still doing my homework on this topic and I'll come up with more detailed info in later days. So to get my hands dirty, I've already downloaded pulseaudio source code and compile it and set it up. Now I find there's a compilation warning, and here's my patch to fix it, cool :) I'm attaching the patch generated from git format-patch, I'm not sure whether it's OK, as I see it from the mailing list, other developers send patches directly in mails. This patch is my first one to get familiar with the workflow, if there's anything wrong, please tell me. :) --rong
From 9ee64a319b43f493730d320038fa7f87108fa5e0 Mon Sep 17 00:00:00 2001 From: Deng Zhenrong <[email protected]> Date: Tue, 20 Mar 2012 22:35:19 +0800 Subject: [PATCH] fix compilation warning modules/alsa/alsa-mixer.c:3110:21: warning: format '%lx' expects argument of type 'long unsigned int', but argument 7 has type 'pa_channel_position_mask_t' [-Wformat] modules/alsa/alsa-mixer.c:3110:21: warning: format '%lx' expects argument of type 'long unsigned int', but argument 8 has type 'pa_channel_position_mask_t' [-Wformat] pa_channel_position_mask_t is type defined to uint64_t, and to display uint64_t, it's better to use PRIx64 primitives. --- src/modules/alsa/alsa-mixer.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/modules/alsa/alsa-mixer.c b/src/modules/alsa/alsa-mixer.c index 102ec82..2e768e9 100644 --- a/src/modules/alsa/alsa-mixer.c +++ b/src/modules/alsa/alsa-mixer.c @@ -3107,7 +3107,7 @@ static pa_bool_t element_is_subset(pa_alsa_element *a, pa_alsa_element *b, snd_m return FALSE; for (s = 0; s < SND_MIXER_SCHN_LAST; s++) if (a->masks[s][a->n_channels-1] != b->masks[s][b->n_channels-1]) { - pa_log_debug("Element %s is not a subset - mask a: 0x%lx, mask b: 0x%lx, at channel %d", + pa_log_debug("Element %s is not a subset - mask a: 0x%" PRIx64 ", mask b: 0x%" PRIx64 ", at channel %d", a->alsa_name, a->masks[s][a->n_channels-1], b->masks[s][b->n_channels-1], s); return FALSE; } -- 1.7.6.5
_______________________________________________ pulseaudio-discuss mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
