On 03/22/2012 02:52 PM, Deng Zhenrong wrote:
modules/alsa/alsa-mixer.c:3110:21: warning: format '%lx' expects argument of type 'long unsigned int', but argument 7 has type 'pa_channel_position_mask_t' [-Wformat] modules/alsa/alsa-mixer.c:3110:21: warning: format '%lx' expects argument of type 'long unsigned int', but argument 8 has type 'pa_channel_position_mask_t' [-Wformat]pa_channel_position_mask_t is type defined to uint64_t, and to display uint64_t, it's better to use PRIx64 primitives.
Seems like most people preferred this version, so I have now pushed your patch. Thanks for your contribution!
Signed-off-by: Deng Zhenrong<[email protected]> --- src/modules/alsa/alsa-mixer.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/modules/alsa/alsa-mixer.c b/src/modules/alsa/alsa-mixer.c index 102ec82..2e768e9 100644 --- a/src/modules/alsa/alsa-mixer.c +++ b/src/modules/alsa/alsa-mixer.c @@ -3107,7 +3107,7 @@ static pa_bool_t element_is_subset(pa_alsa_element *a, pa_alsa_element *b, snd_m return FALSE; for (s = 0; s< SND_MIXER_SCHN_LAST; s++) if (a->masks[s][a->n_channels-1] != b->masks[s][b->n_channels-1]) { - pa_log_debug("Element %s is not a subset - mask a: 0x%lx, mask b: 0x%lx, at channel %d", + pa_log_debug("Element %s is not a subset - mask a: 0x%" PRIx64 ", mask b: 0x%" PRIx64 ", at channel %d", a->alsa_name, a->masks[s][a->n_channels-1], b->masks[s][b->n_channels-1], s); return FALSE; }
-- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic _______________________________________________ pulseaudio-discuss mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
