On Tue, 2012-07-10 at 19:26 +0200, Paul Menzel wrote: > Am Dienstag, den 10.07.2012, 00:59 +0800 schrieb Deng Zhengrong: > > <option> > > + <p><opt>set-log-target</opt> <arg>target</arg></p> > > + <optdesc><p>Change the log > > target(null,auto,syslog,stderr,file:PATH).</p></optdesc> > > In English a space is always added before a parenthesis (. Maybe also > add a space after each comma »,«. > > Change the log target (null, auto, syslog, stderr, file:PATH). > > Sorry, it just came to my mind that you can also note what the default > target is. So I guess you can try out `--subject-prefix="PATCH v3"` > now. ;-)
I don't really agree about noting the default target. That belongs in the daemon.conf documentation, not in the cli syntax documentation. As far as I can see, knowing the default target doesn't help the user when he wants to change the log target at runtime with pacmd. The meaning of the different targets, especially "auto", could be explained somehow, however. Thank you very much for doing patch review, btw! It's appreciated. -- Tanu _______________________________________________ pulseaudio-discuss mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
