On Fri, Nov 09, 2012 at 08:17:02PM +0200, Tanu Kaskinen wrote:
> 
> The ports variable contains all ports of a card. Here I think you add
> all output ports of a card to all sinks of the card and all input ports
> to all sources. That's not right, a sink may have only a subset of the
> card's output ports assigned to it.
> 
> The "plugged in" and "unplugged" strings should probably be
> translatable. (Same for the profile code.)
> 

Good catch. I got myself thinking that I could generalize the solution a
little bit but it seems that we can't figure out which port belongs
where just from pa_card_port_info.

> 
> I think profiles should be "plugged in" if any port is available.
> 

For what its worth I agree with Tanu here.

I'll send a v2 of the patch next week.
_______________________________________________
pulseaudio-discuss mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Reply via email to