On Jul 18, 2013 10:55 AM, "Tanu Kaskinen" <[email protected]> wrote: > > On Fri, 2013-07-12 at 15:06 -0300, [email protected] wrote: > > From: João Paulo Rechi Vita <[email protected]> > > > > --- > > src/modules/bluetooth/bluez5-util.c | 101 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 101 insertions(+) > > > > diff --git a/src/modules/bluetooth/bluez5-util.c b/src/modules/bluetooth/bluez5-util.c > > > +static DBusHandlerResult filter_cb(DBusConnection *bus, DBusMessage *m, void *userdata) { > > + pa_bluetooth_discovery *y; > > + DBusError err; > > + const char *path, *interface, *member; > > + > > + pa_assert(bus); > > + pa_assert(m); > > + pa_assert_se(y = userdata); > > + > > + path = dbus_message_get_path(m); > > + interface = dbus_message_get_interface(m); > > + member = dbus_message_get_member(m); > > + > > + pa_log_debug("dbus: path=%s, interface=%s, member=%s", path, interface, member); > > I don't like this message, it spams the log with all D-Bus traffic, > which does more harm than good IMO. >
I personally like it, but I agree it doesn't scale well as we add more filter_cb functions (the oFono backend has a new one, for example) and that dbus-monitor should substitute this line well enough. I'll send an updated version.
_______________________________________________ pulseaudio-discuss mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
